Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

ENH: Build Python3.10.0rc1 64 bit wheels on Intel. #129

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

charris
Copy link
Contributor

@charris charris commented Aug 10, 2021

No description provided.

AZURE_PYTHON_VERSION: "3.9"
MB_PYTHON_VERSION: "3.10"
MB_ML_VER: "2014"
CONFIG_PATH: "config_ilp64.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I uploaded focal images, let's give it a try. They will not be available for 32-bit linux

Suggested change
CONFIG_PATH: "config_ilp64.sh"
CONFIG_PATH: "config_ilp64.sh"
DOCKER_TEST_IMAGE: "multibuild/focal_{PLAT}"

PLAT: "i686"
MB_ML_VER: "2014"
ENV_VARS_PATH: "env_vars_32.sh"
DOCKER_TEST_IMAGE: "multibuild/xenial_{PLAT}"
Copy link
Contributor

@mattip mattip Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 32-bit is not really supported anymore in Ubuntu, just test with the manylinux image

Suggested change
DOCKER_TEST_IMAGE: "multibuild/xenial_{PLAT}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, this doesn't actually test with the manylinux image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are currently run via this line

+ docker run --rm -e PYTHON_VERSION=3.7 -e MB_PYTHON_VERSION=3.7 \
    -e UNICODE_WIDTH=32 -e CONFIG_PATH= -e WHEEL_SDIR=wheelhouse \
    -e MANYLINUX_URL= -e 'TEST_DEPENDS=pytest hypothesis cffi pytz' \
    -v /home/vsts/work/1/s:/io multibuild/xenial_i686 /io/multibuild/docker_test_wrap.sh

which uses multibuild/xenial_i686. I was intending for it to use the manylinux image instead by removing the line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the line the build still worked, but there was no 3.10 for the test, the docker image defaults to the multibuild xenial version for testing. I just commented out the 32 bit and ARM64 builds. I assume both will get fixed at some point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume both will get fixed at some point.

The arm64 image for focal now exists. On i686 we are stuck testing on the manylinux image since 32-bit images do not exist for current Ubuntu distributions.

@charris charris force-pushed the try-python3.10-wheels branch from 499130b to 2264bc9 Compare August 10, 2021 15:17
@charris charris changed the title ENH: Build Python3.10.0rc1 wheels. ENH: Build Python3.10.0rc1 64 bit wheels on Intel. Aug 10, 2021
@charris charris merged commit b355127 into MacPython:main Aug 10, 2021
@charris
Copy link
Contributor Author

charris commented Aug 10, 2021

Merging. All the tests have passed, but github had problems and missed the notifications.

@charris charris deleted the try-python3.10-wheels branch August 10, 2021 17:21
tylerjereddy added a commit to tylerjereddy/scipy-wheels that referenced this pull request Aug 13, 2021
* mimic the approach used by NumPy wheels
in: MacPython/numpy-wheels#129

* what could go wrong.. (skip Travis for now)

[skip travis] [skip travis ci] [skip travis-ci] [travis skip]
tylerjereddy added a commit to tylerjereddy/scipy-wheels that referenced this pull request Aug 13, 2021
* mimic the approach used by NumPy wheels
in: MacPython/numpy-wheels#129

* what could go wrong.. (skip Travis for now)

[skip travis] [skip travis ci] [skip travis-ci] [travis skip]
tylerjereddy added a commit to tylerjereddy/scipy-wheels that referenced this pull request Aug 14, 2021
* mimic the approach used by NumPy wheels
in: MacPython/numpy-wheels#129

* what could go wrong.. (skip Travis for now)

[skip travis] [skip travis ci] [skip travis-ci] [travis skip]
tylerjereddy added a commit to tylerjereddy/scipy-wheels that referenced this pull request Aug 14, 2021
* mimic the approach used by NumPy wheels
in: MacPython/numpy-wheels#129

* what could go wrong.. (skip Travis for now)

[skip travis] [skip travis ci] [skip travis-ci] [travis skip]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants