-
Notifications
You must be signed in to change notification settings - Fork 18
Comments
Fine by me. But I'm not a scikit-learn admin. |
Isn't the initial motivation somewhat similar to that of conda-forge? i.e. that it's easier to maintain all these repos in one place. For instance, adapting the changes/updates of CI config from one repo into others would be more difficult if they are spread in multiple orgs? Also, there is the question that the CI needs credentials to upload wheels to a rackspace container (that also contains wheels from other projects), and if repos are moved to their respective orgs, that increases the vulnerability surface because more people would have access to it? Of course, the risk is more of stolen credentials than any intentional wrongdoing... |
It's probably useful to let me have write access to tthe repo, so I can add fixes when something in the CI framework changes, but you can do that from the scikit-learn org, if y'all take ownership. The credentials are encrypted, so I just have to re-encrypt them, when you move to another repository. Unless someone can break the encryption, they can't get the credentials. |
I meant that since the CI decrypts those to use them, having to write access to this repo is equivalent to having access to the credentials (unless I'm missing something). More people would have write access to it if it is moved to the scikit-learn org (we also currently don't require 2FA from core devs). Though, I agree that it's probably a relatively low risk. Granted we can restrict access more on the scikit-learn org side, but I'm wondering not so much about this particular case, but more about moving repos out of this org in general.. What does @ogrisel think about it? |
My motivation was that we need to duplicate core dev authorisation here
|
Also, people keep thinking that this repo is about Mac, and I keep forgetting the URL or typing https://github.com/scikit-learn/scikit-learn-wheels into my address bar. |
I agree that the name of this org is confusing.
Indeed, we also need to do it for conda-forge, but in practice, not all core devs are involved in the final step of building wheels. IMO, because building binary artifacts distributed on PyPi has different security implications than having commit rights on the main git repo, giving access to people who show interest is better than giving it by default to all core devs. Again purely from the perspective of loss of credentials etc. My main concerns against it are,
|
For instance, to give a concrete example Azure builds #23 is something that might interest other projects (numpy, scipy etc.). Currently, it's fairly easy to find that PR by searching in the org, it won't be the case if it's not part of this org. |
I am fine with the change as well. |
Feel free to move it then. |
No description provided.
The text was updated successfully, but these errors were encountered: