Skip to content
This repository was archived by the owner on Feb 14, 2023. It is now read-only.

[MRG] Enable Azure pipelines for builds with uploads to anaconda.org #23

Merged
merged 197 commits into from
Feb 12, 2020

Conversation

thomasjpfan
Copy link
Collaborator

@thomasjpfan thomasjpfan commented Mar 7, 2019

This PR reproduces the current behavior of our travis + appveyor setup. You can see the pipeline here.

  • With some tweaks to this PR, I can see placing this pipeline into the main scikit-learn repo and have it automatically push the wheels into pypi when a tag is added.

  • Alternatively we could just move the repo to the scikit-learn org.

  • For this pipeline to upload to anaconda SCIKIT_LEARN_NIGHTLY_UPLOAD_TOKEN and SCIKIT_LEARN_STAGING_UPLOAD_TOKEN needs to be defined as a secret variables.

Edit: updated by @ogrisel to reflect the changes related to the switch from rackspace to anaconda.org.

This branch has been tested on this Azure Pipelines account:

https://dev.azure.com/ogrisel2/scikit-learn-wheels/_build?definitionId=2&_a=summary

We need to create a new project in the scikit-learn org for the final branch to work:

https://dev.azure.com/scikit-learn/scikit-learn-wheels

@ogrisel ogrisel changed the title [WIP] Enable Azure pipelines for builds [MRG] Enable Azure pipelines for builds with uploads to anaconda Feb 12, 2020
@ogrisel ogrisel changed the title [MRG] Enable Azure pipelines for builds with uploads to anaconda [MRG] Enable Azure pipelines for builds with uploads to anaconda.org Feb 12, 2020
Copy link
Collaborator

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should then also update the maintainer.rst I guess.

py_3.8_32:
MB_PYTHON_VERSION: "3.8"
PLAT: "i686"
NP_BUILD_DEP: "numpy==1.17.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't wanna use oldest-supported-numpy ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oldest-supported-numpy that also works on Python 3.8.

@adrinjalali
Copy link
Collaborator

Why aren't the azure pipelines running here?

@ogrisel
Copy link
Contributor

ogrisel commented Feb 12, 2020

Why aren't the azure pipelines running here?

I need admin rights to create the project on azure under the scikit-learn org. I will sent and email on the internal mailing list.

@ogrisel
Copy link
Contributor

ogrisel commented Feb 12, 2020

If you want to see example runs for the current state of this branch, have a look at my test azure devops account:

https://dev.azure.com/ogrisel2/scikit-learn-wheels/_build?definitionId=2&_a=summary

@ogrisel
Copy link
Contributor

ogrisel commented Feb 12, 2020

we should then also update the maintainer.rst I guess.

Where?

@ogrisel
Copy link
Contributor

ogrisel commented Feb 12, 2020

Ok let's merge. I will use my Azure account for the master branch of this repo for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants