Skip to content
This repository was archived by the owner on Feb 14, 2023. It is now read-only.

Fix macos version matrix #29

Merged
merged 6 commits into from
May 24, 2019

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented May 23, 2019

I think I understand the issue described in scikit-learn/scikit-learn/pull/13915#issuecomment-495319072:

The test dependencies are not updated to the latest stable automatically: so it can be the case that building on old numpy could run the tests on a too recent version of scipy that would cause problem at test time.

Let's see if pinning everything fixes the problem.

ogrisel added 2 commits May 23, 2019 23:16
Group all macOS entries together.
Remove redundant entry for Python 3.5.
Pin scipy version for python 3.6 build.
@jnothman
Copy link
Collaborator

Why are no Travis runs starting?

@jnothman
Copy link
Collaborator

Now some Linux builds are failing: they are trying to build wheels for numpy and scipy, and the scipy build is failing because numpy isn't there yet... Or at least that's my interpretation

@jnothman
Copy link
Collaborator

None of the jobs marked daily build are working here now

@jnothman
Copy link
Collaborator

jnothman commented May 24, 2019 via email

Copy link
Collaborator

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have wheels built for all but Mac on Py3.6. There it is going through the same compilation errors as the linux builds due to no wheel for Scipy on that platform, it seems.

jnothman added 2 commits May 24, 2019 12:54
Let's just see if we can ship that wheel then look into longer-term fixes.
@jnothman
Copy link
Collaborator

The build I wanted finished but didn't upload for some unknown reason...

@jnothman
Copy link
Collaborator

I'll twine the wheels I have for now.

@ogrisel
Copy link
Contributor Author

ogrisel commented May 24, 2019

Indeed we need to find the oldest known good set of dependicies for numpy / scipy for each Python version to build the scikit-learn wheel and the the most recent known good set of dependicies for numpy / scipy to run the tests.

@ogrisel
Copy link
Contributor Author

ogrisel commented May 24, 2019

It seems we are going to release on Friday again :)

@ogrisel
Copy link
Contributor Author

ogrisel commented May 24, 2019

I don't know the English version but I think you can guess the meaning: https://www.estcequonmetenprodaujourdhui.info/

@jnothman
Copy link
Collaborator

I think if we changed macpython to install numpy strictly before scipy, it could work... Anyway, it's green here and so, pending the switch to Azure, we should merge

@jnothman jnothman merged commit de28641 into MacPython:master May 24, 2019
@jnothman
Copy link
Collaborator

jnothman commented May 24, 2019 via email

@ogrisel
Copy link
Contributor Author

ogrisel commented May 24, 2019

Yes I will. Thanks for fixing the remaining builds.

@ogrisel ogrisel deleted the fix-macos-version-matrix branch May 24, 2019 06:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants