Skip to content
This repository was archived by the owner on Feb 14, 2023. It is now read-only.

Preparing a beta release: set BUILD_COMMIT to 0.22b1 #33

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Preparing a beta release: set BUILD_COMMIT to 0.22b1 #33

merged 2 commits into from
Nov 15, 2019

Conversation

adrinjalali
Copy link
Collaborator

Preparing a beta release. The branch and the tag are already on the scikit-learn repo.

@jnothman
Copy link
Collaborator

jnothman commented Nov 7, 2019

We gave up on betas a few years back, jumping to rcs. But this is good too!

@adrinjalali
Copy link
Collaborator Author

I opted for a beta since some issues are not solved, and as you mentioned we still may add some features. But the main reason, is that I didn't want my first release to be an RC. This is partly beta because I'm still learning the steps and didn't want to accidentally release something which people may rely on while there's a chance that they shouldn't ;)

@jnothman
Copy link
Collaborator

jnothman commented Nov 7, 2019 via email

@adrinjalali
Copy link
Collaborator Author

I can remove the beta tag and replace it with an rc1 if you prefer.

@jnothman
Copy link
Collaborator

jnothman commented Nov 8, 2019 via email

@amueller
Copy link
Contributor

amueller commented Nov 8, 2019

yeah someone might ask "what's the difference between an rc and a beta". So I'm +0.5 for rc

@adrinjalali
Copy link
Collaborator Author

This now passes the CI and has 0.22rc1 as the version tag.

If I understand correctly, this PR needs to be merged so that the wheels are uploaded to wheels.scipy.org, so that I can continue with the release?

@rth
Copy link
Contributor

rth commented Nov 13, 2019

Do we want to add Python 3.8 wheels as well for the rc #34? As far as I understood tests were passing locally, so it's mostly about adding the corresponding CI entries in this repo I think.

@adrinjalali
Copy link
Collaborator Author

Do we need it for the RC? I rather get the RC out, then add the few things which we need to add for the release.

@jnothman
Copy link
Collaborator

jnothman commented Nov 13, 2019 via email

@adrinjalali
Copy link
Collaborator Author

The next one can be an RC2 or a release. I'm not sure if the preconditioning needs to be in an RC first, but I'm happy to do an RC2 with that and some other fixes we have in the backlog before the release if that's what you think is appropriate.

@jnothman
Copy link
Collaborator

Let's merge this and get it onto wheels.scipy.

@jnothman
Copy link
Collaborator

But we've also made a few changes since this was tagged, so it would be good practice to then make another RC afterwards

@jnothman jnothman merged commit bd0c867 into MacPython:master Nov 15, 2019
@adrinjalali adrinjalali deleted the 0.22b1 branch November 18, 2019 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants