Skip to content
This repository was archived by the owner on Feb 14, 2023. It is now read-only.

[WIP] Adds python 3.8 wheels #35

Merged
merged 30 commits into from
Nov 25, 2019
Merged

Conversation

thomasjpfan
Copy link
Collaborator

@thomasjpfan thomasjpfan commented Nov 16, 2019

Adds python 3.8 wheels

Closes #34

@thomasjpfan
Copy link
Collaborator Author

Update: test_scale_and_stability is failing on 64 bit windows.

@thomasjpfan
Copy link
Collaborator Author

Moving to 1.2.2 resolves the issue so this seems to be scipy 1.3.* issue on windows 64bit

@jnothman jnothman requested a review from rth November 19, 2019 19:39
@jnothman
Copy link
Collaborator

So I suppose this will work if we change the BUILD_COMMIT to 0.20.X

@jnothman
Copy link
Collaborator

yes, master not 0.22.X :)

@thomasjpfan
Copy link
Collaborator Author

YESSS all the wheels can be built on master!

@adrinjalali
Copy link
Collaborator

Awesome, thanks @thomasjpfan . @rth does it look good to you?

@jnothman
Copy link
Collaborator

I think my review request was accidental

Copy link
Collaborator

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@adrinjalali
Copy link
Collaborator

@jnothman could you please then merge this? (I don't have permissions here)

@jnothman jnothman merged commit 7e4a2ec into MacPython:master Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.8 wheels
3 participants