Skip to content

Fix Trying to access array offset on value of type null #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Trying to access array offset on value of type null #170

wants to merge 1 commit into from

Conversation

remicollet
Copy link
Contributor

With PHP 7.4.0RC3

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.0RC3
Configuration: /dev/shm/BUILD/html5-php-104443ad663d15981225f99532ba73c2f1d6b6f2/phpunit.xml.dist

...............................................................  63 / 170 ( 37%)
.......................................EE...................... 126 / 170 ( 74%)
............................................                    170 / 170 (100%)

Time: 80 ms, Memory: 6.00MB

There were 2 errors:

1) Masterminds\HTML5\Tests\Parser\TokenizerTest::testTagsWithAttributeAndMissingName
Trying to access array offset on value of type null

/dev/shm/BUILD/html5-php-104443ad663d15981225f99532ba73c2f1d6b6f2/test/HTML5/Parser/TokenizerTest.php:29
/dev/shm/BUILD/html5-php-104443ad663d15981225f99532ba73c2f1d6b6f2/test/HTML5/Parser/TokenizerTest.php:488

2) Masterminds\HTML5\Tests\Parser\TokenizerTest::testTagNotClosedAfterTagName
Trying to access array offset on value of type null

/dev/shm/BUILD/html5-php-104443ad663d15981225f99532ba73c2f1d6b6f2/test/HTML5/Parser/TokenizerTest.php:29
/dev/shm/BUILD/html5-php-104443ad663d15981225f99532ba73c2f1d6b6f2/test/HTML5/Parser/TokenizerTest.php:514

ERRORS!
Tests: 170, Assertions: 2023, Errors: 2.

@goetas
Copy link
Member

goetas commented Oct 11, 2019

Can you please add also the php 7.4 build on travis to this?

@goetas goetas self-assigned this Oct 11, 2019
@remicollet
Copy link
Contributor Author

remicollet commented Oct 14, 2019 •
edited
Loading

Can you please add also the php 7.4 build on travis to this?

Sorry, but no
I don't know anything about travis, which is always far behind upstream, I that I don't use, and don't want to learn

More, this out of the scope of this PR, which only fixes 1 issue encounter with 7.4.0RC3, and don't really plan to fix PHP 7.4 compatibility / support, as I do'nt even know what code coverage the test suite have. This is project owner responsability.

@goetas
Copy link
Member

goetas commented Oct 14, 2019 •
edited
Loading

done in #171, thanks @xabbuh

@goetas goetas closed this Oct 14, 2019
@remicollet remicollet deleted the issue-php74 branch October 14, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@goetas goetas

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remicollet @goetas