Change options watch handler to update values via native Sortable method #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MaxLeiter
approved these changes
Aug 25, 2022
|
thank you! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
groupoption is manipulated by Sortable to includecheckPutandcheckPullmethods, when Sortable-vue3 detects options have changed, it overwrites the options property on Sortable directly.This means you lose
checkPutandcheckPull(destructuring is only a shallow merge), causing errors when you try to drag between groups.To resolve, I've changed the watch handler to use the
optionmethod on the Sortable object, looping through and updating the values one by one.This seems to have resolved the issue.
I've also had to move the prop type out into a dedicated type to keep TS happy.