Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search results nav F4 conflicts with the C++ extension #18679

Closed
roblourens opened this issue Jan 17, 2017 · 5 comments
Closed

Search results nav F4 conflicts with the C++ extension #18679

roblourens opened this issue Jan 17, 2017 · 5 comments
Assignees
@roblourens
Milestone
January 2017

Comments

@roblourens
Copy link
Member

@egamma What problem did you say you had with shift+f4? It works as expected for me.
@roblourens roblourens self-assigned this Jan 17, 2017
@egamma
Copy link
Member

egamma commented Jan 17, 2017 •
edited
Loading

@roblourens my problem was that 'F4' gives focus to the editor and I could not press it repeatedly. I've tried to reproduce it with all extensions disabled and it worked well. Sorry about the false issue.

@egamma egamma closed this as completed Jan 17, 2017
@egamma
Copy link
Member

egamma commented Jan 17, 2017 •
edited
Loading

@roblourens the culprit is the C++ extension and the SwitchHeaders command (see below).
This means the users of the C++ extensions will have the same issue.

image

@egamma egamma reopened this Jan 17, 2017
@egamma
Copy link
Member

egamma commented Jan 17, 2017

Given that the C++ extension is popular we should "fix this" by announcing this as a "breaking" key binding change in the release notes.

@roblourens roblourens added this to the January 2017 milestone Jan 17, 2017
@BillDenton BillDenton mentioned this issue Jan 18, 2017
Closed
@egamma egamma changed the title Search results nav - shift+f4 Search results nav F4 conflicts with the C++ extension Jan 18, 2017
@BillDenton
Copy link

Shouldn't this be moved to C++ extension and the extension change its key mapping?

@roblourens roblourens mentioned this issue Jan 23, 2017
Closed
roblourens added a commit to microsoft/vscode-docs that referenced this issue Jan 23, 2017
@roblourens
Add note about F4 keybinding conflicts to fix microsoft/vscode#18679
ed2a143
@roblourens
Copy link
Member Author

Filed an issue on vscode-cpptools, and added to the release notes

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
January 2017
Development

No branches or pull requests
3 participants
@egamma @roblourens @BillDenton