-
Notifications
You must be signed in to change notification settings - Fork 529
connect workflow to azure keyvault - quick start #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Learn Build status updates of commit 58ccf2a:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/github/connect-keyvault.md | Details |
articles/github/connect-keyvault.md
- Line 7, Column 13: [Warning: ms-service-subservice-invalid - See documentation]
Invalid value for 'ms.service': 'azure-keyvault'.
- Line 9, Column 10: [Warning: ms-date-invalid - See documentation]
Value out of range for 'ms.date': '05/03/2025'. If specified, must be a date in format M/D/YYYY, no more than 30 days from today. If you don't specify ms.date, the date will be updated automatically.
- Line 42, Column 1: [Warning: code-block-indented - See documentation]
Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
- Line 179, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/active-directory/external-identities/what-is-b2b' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 180, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-network/service-tags-overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 181, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-openid-connect' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 182, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-secret' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation]
Invalid value for 'ms.author', 'theluckyprogrammer' is not a valid Microsoft alias.
- Line 179, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/external-identities/what-is-b2b' will be broken in isolated environments. Replace with a relative link.
- Line 180, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-network/service-tags-overview' will be broken in isolated environments. Replace with a relative link.
- Line 181, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-openid-connect' will be broken in isolated environments. Replace with a relative link.
- Line 182, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-secret' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
@theluckyprogrammer Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request. Thanks! #label:"aq-pr-triaged" |
@microsoft-github-policy-service agree |
Learn Build status updates of commit 29a57dc:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/github/connect-keyvault.md | Details |
articles/github/connect-keyvault.md
- Line 7, Column 13: [Warning: ms-service-subservice-invalid - See documentation]
Invalid value for 'ms.service': 'azure-keyvault'.
- Line 9, Column 10: [Warning: ms-date-invalid - See documentation]
Value out of range for 'ms.date': '05/03/2025'. If specified, must be a date in format M/D/YYYY, no more than 30 days from today. If you don't specify ms.date, the date will be updated automatically.
- Line 165, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/active-directory/external-identities/what-is-b2b' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 166, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-network/service-tags-overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 167, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-openid-connect' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 168, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-secret' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation]
Invalid value for 'ms.author', 'theluckyprogrammer' is not a valid Microsoft alias.
- Line 165, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/external-identities/what-is-b2b' will be broken in isolated environments. Replace with a relative link.
- Line 166, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-network/service-tags-overview' will be broken in isolated environments. Replace with a relative link.
- Line 167, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-openid-connect' will be broken in isolated environments. Replace with a relative link.
- Line 168, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-secret' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit ebe9d36:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/github/connect-keyvault.md | Details |
articles/github/connect-keyvault.md
- Line 7, Column 13: [Warning: ms-service-subservice-invalid - See documentation]
Invalid value for 'ms.service': 'azure-keyvault'.
- Line 9, Column 10: [Warning: ms-date-invalid - See documentation]
Value out of range for 'ms.date': '05/03/2025'. If specified, must be a date in format M/D/YYYY, no more than 30 days from today. If you don't specify ms.date, the date will be updated automatically.
- Line 165, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/active-directory/external-identities/what-is-b2b' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 166, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-network/service-tags-overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 167, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-openid-connect' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 168, Column 5: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-secret' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation]
Invalid value for 'ms.author', 'theluckyprogrammer' is not a valid Microsoft alias.
- Line 165, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/external-identities/what-is-b2b' will be broken in isolated environments. Replace with a relative link.
- Line 166, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-network/service-tags-overview' will be broken in isolated environments. Replace with a relative link.
- Line 167, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-openid-connect' will be broken in isolated environments. Replace with a relative link.
- Line 168, Column 5: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure-secret' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
I'll address warnings tomorrow |
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
changes related to PR suggestions
@theluckyprogrammer : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit 6291dc3:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/github/connect-keyvault.md | Details |
articles/github/connect-keyvault.md
- Line 7, Column 13: [Warning: ms-service-subservice-invalid - See documentation]
Invalid value for 'ms.service': 'azure-keyvault'.
- Line 164, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: '../../../../entra-docs/docs/external-id/what-is-b2b.md'.
- Line 165, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: '../../../../azure-docs/articles/virtual-network/service-tags-overview.md'.
- Line 2, Column 1: [Suggestion: ms-date-missing - See documentation]
Missing required attribute: 'ms.date'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
PR recommendations: - corrected relative file links
Update connect-keyvault.md
Learn Build status updates of commit dfd3df5:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/github/connect-keyvault.md | Details |
articles/github/connect-keyvault.md
- Line 9, Column 10: [Warning: ms-date-invalid - See documentation]
Invalid date format for 'ms.date': '/3/9/2025'. If specified, must be a date in format M/D/YYYY, no more than 30 days from today. If you don't specify ms.date, the date will be updated automatically.
- Line 165, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: '~/_entra-docs/docs/external-id/what-is-b2b.md'.
- Line 166, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: '~/_azure-docs/articles/virtual-network/service-tags-overview.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
I have no clue who to set as an author, so I've set @juliakm because she was displayed as a reviewer on the PR list level above. |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @juliakm |
@theluckyprogrammer Thanks for your contribution! I'm going to pull your contribution into our private repo to make edits. In particular, I'd like to include your code for retrieving a key vault secret in another article. |
#please-close |
I was teaching my students how to build CI/CD in GitHub, and such a document would be helpful.
One of the steps was to get secrets from the key vault, an important step and one of the most basic during application deployment.