Add Maven dependency for JDK HttpClient; update versions #1441
Conversation
|
@christarczon : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 28a9bd9: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
@christarczon thanks for the pull request! |
| <version>1.12.10</version> | ||
| </dependency> | ||
|
|
||
| <!-- JDK 11 HttpClient --> |
There was a problem hiding this comment.
The JDK HttpClient was introduced in 11 but due to certain limitations with how HTTP headers are handled in JDK 11, we recommend using this library only with JDK 12+. So, in the comment, it would be better to mention that this is suitable only for JDK 12+ applications.
There was a problem hiding this comment.
There's an existing note above that it's only supported with 12+, I was matching another comment below. I could drop the 11 and keep it simply JDK HttpClient in both cases.
There was a problem hiding this comment.
That works. We can simply drop the version from this comment and the note above should be sufficient.
There was a problem hiding this comment.
@christarczon If you need help making this edit, please let us know.
|
Learn Build status updates of commit e0690cb: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@microsoft-github-policy-service agree |
|
Thanks, @christarczon ! |
I had trouble finding the artifact for the JDK HttpClient which I think belongs in this doc. I also updated the versions of the others to be current.