Skip to content

Conversation

EmilEnchev
Copy link
Contributor

@EmilEnchev EmilEnchev commented Jun 18, 2019

Can someone explain to me, when I make changes - to do or not to do pull requests?! I'm totally new here and I don't understand yet the Github's mechanic. If I only propose file changes is this enough?

Another thing that I don't understand is why when I make pull request it forked from MicrosoftDocs/cpp-docs to my Repositories? Should I then delete this fork after you've approve or disapprove the changes?

Best regards,
Emil Enchev

Can someone explain to me, when I make changes - to do or not to do pull requests?! I'm totally new here and I don't understand yet the Github's mechanic. If I only propose file changes is this enough?
@PRMerger14
Copy link
Contributor

@EmilEnchev : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmilEnchev Good catch, I forgot to paste those bits in from my built examples.

@colin-home
Copy link
Contributor

colin-home commented Jun 18, 2019

Can someone explain to me, when I make changes - to do or not to do pull requests?! I'm totally new here and I don't understand yet the Github's mechanic. If I only propose file changes is this enough?
Another thing that I don't understand is why when I make pull request it forked from MicrosoftDocs/cpp-docs to my Repositories? Should I then delete this fork after you've approve or disapprove the changes?
Best regards,
Emil Enchev

There are two ways to make a PR to the public repo: If you use the GitHub web interface to edit a file, it creates a fork of the repo for you if you don't have one already. The change is put in a branch with a name like "patch-2". Then this branch is used for the PR. Whether to delete the fork or not is up to you.
You can also work in your own fork of the repo. If you do, then you can include more than one file at a time in a PR. This is more advanced. If you have a complicated change, you should create an issue first for discussion, then make the PR.
The whole process is described in our Microsoft Docs contributor guide overview.

@colin-home colin-home merged commit bb63f8c into MicrosoftDocs:master Jun 18, 2019
@EmilEnchev
Copy link
Contributor Author

EmilEnchev commented Jun 19, 2019

Thanks @corob-msft I will read Microsoft Docs contributor guide now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants