-
Notifications
You must be signed in to change notification settings - Fork 973
Make the struct packing for ARM64EC more clear #4025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove the confusing "Consider a field that has an alignment specifier. Empirically, x64 rounds the size of the struct to the next multiple of the alignment, whereas ARM64 rounds the size of the struct to the next multiple of 8." and make the ARM64EC struct packing rules more clear.
@mcfi : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
I have a simple grammar mistake I want to correct, one sec |
@mcfi : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Docs Build status updates of commit 7bb4d9f: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 73d6a25: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
IMPORTANT: When this content is ready to merge, the reviewer must add #label:"aq-pr-triaged" |
@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Docs Build status updates of commit b5f1c7e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
#sign-off |
Just curious if the build automation extends to automatic merges. Doesn't look like it. |
Docs Build status updates of commit b5f1c7e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Remove the confusing "Consider a field that has an alignment specifier. Empirically, x64 rounds the size of the struct to the next multiple of the alignment, whereas ARM64 rounds the size of the struct to the next multiple of 8." and make the ARM64EC struct packing rules more clear.