Skip to content

Conversation

snakecase
Copy link

Browsers render /Fopathname as two separate strings which confuses those who want to quickly glance at the syntax and move on. "Remarks" section clearly says "Don't put a space between the /Fo option and the pathname argument".

Browsers render **`/Fo`***`pathname`* as two separate strings which confuses those who want to quickly glance at the syntax and move on. "Remarks" section clearly says "Don't put a space between the /Fo option and the pathname argument".
@prmerger-automator
Copy link
Contributor

@snakecase : Thanks for your contribution! The author(s) have been notified to review your proposed change.

1 similar comment
@prmerger-automator
Copy link
Contributor

@snakecase : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@snakecase : Thanks for your contribution! The author(s) have been notified to review your proposed change.

3 similar comments
@prmerger-automator
Copy link
Contributor

@snakecase : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@snakecase : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@snakecase : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit dc9c452:

✅ Validation status: passed

File Status Preview URL Details
docs/build/reference/fo-object-file-name.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@snakecase : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented Feb 14, 2023

@corob-msft

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Feb 14, 2023
@prmerger-automator
Copy link
Contributor

@snakecase : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snakecase
I appreciate your initiative and commend you for looking out for your fellow docs users. Your intentions are good, but they've run into an issue we've argued about with the team in charge of our CSS styling for years. The title doesn't need to be changed, since the part in parentheses is the description of the option, not the description of the argument to the option. The syntax block, on the other hand, isn't supposed to look like it has a space between the option and the pathname. The only reason it does is because the CSS for code styling has some unnecessary horizontal padding, and we have to apply the bold code styling and the italicized code styling in separate sections. We've opted to stick with the standardized styling and live with the apparent space, making sure to comment that it isn't supposed to be there. It's an imperfect solution, but for consistency across the docs it's what we're sticking with for now. My apologies for not accepting your PR.

@colin-home
Copy link
Contributor

Closing as not consistent with our style.

@colin-home colin-home closed this Feb 16, 2023
@snakecase
Copy link
Author

Sad that consistency (especially where it clearly works against the user) takes precedence over common sense. This PR was made only because a few people on my team have already lost some time trying to figure out why the command doesn't work and were really confused about documentation confirming their expectations of /command argument format.

I propose to put the Don't put a space between the /Fo option and the pathname argument as the first sentence at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants