-
Notifications
You must be signed in to change notification settings - Fork 973
Update 'Connect to your target Linux system in Visual Studio'. #4464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Clearly state that Windows' default `ssh-keygen` does not produce valid private keys for use with ConnectionManager/VS, including steps to adjust private keys to conform with it.
@fkelava : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit e5af654: ✅ Validation status: passed
For more details, please refer to the build report. Note: Links can become broken if there are changes on the target sites. For any questions, please:
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
To summarize the issue more neatly: Visual Studio's The problem is not so much the fact that It is mentioned in Set up FIPS-compliant secure remote Linux development, but I find it unintuitive that a general requirement for all private keys should be found in an article concerning FIPS compliance. Making this clear in the documentation is merely a stopgap, but the issue should be properly resolved by finally updating I am open to suggestions on rewording this, placing it in a better position in the article, or reworking it in any way you deem fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkelava , thank you for adding this to the docs! It should be live by end of day Monday.
#sign-off |
Well I am currently ratholing into this issue and using |
If I haven't misread the man page, it seems the equivalent command is now If so, I can amend the docs again. |
I did get it to eventually work by making a new key, but it was pointless because debugging a self contained .NET binary remotely doesn't work anyway. |
Clearly state that Windows' default
ssh-keygen
does not produce valid private keys for use with ConnectionManager/VS, including steps to adjust private keys to conform with it.Specifically, the reasoning behind this change and the underlying issue are explained clearly in the following Developer Community tickets and SO threads:
https://developercommunity.visualstudio.com/t/Connect-to-Remote-System-fails-to-esta/10311053
https://developercommunity.visualstudio.com/t/cannot-connect-to-remote-using-private-key/1555749
https://stackoverflow.com/questions/53134212/invalid-privatekey-when-using-jsch
Until such a time as ConnectionManager is fixed to be compliant with default
ssh-keygen
options in modern Windows editions, it should be stated clearly that this is not the case and how this can be resolved.