Standardize C++ version naming #4863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rageking8
commented
Dec 24, 2023
|
|
||
| // 18) time_zone_link | ||
| bool operator==(const time_zone_link& Left, const time_zone_link& Right) noexcept; | ||
| bool operator==(const time_zone_link& Left, const time_zone_link& Right) noexcept; // C++20 |
There was a problem hiding this comment.
This is missing the C++20 label, added it as a drive-by.
PRMerger Results
|
|
@TylerMSFT - is this yours to review? If not, you can reassign or let me know who to assign. Thanks!
#label:"aq-pr-triaged" |
TylerMSFT
approved these changes
Jan 4, 2024
|
#sign-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canonical way to represent a C++ version (only the last 2 digits of the year) is without the extra space character (i.e. either C++20 or C++ 2020). This PR removes all extra spaces as the canonical version is more prevalent in this docs repository and is used as such in the official ISO website.