Skip to content

Fix unclosed links #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2024
Merged

Fix unclosed links #5052

merged 2 commits into from
Jun 19, 2024

Conversation

HarryGwinnell
Copy link

Fix unclosed link tags causing the whole page to appear as a link.

e.g. After Filename Macros in Special NMAKE macros, the unclosed link makes the paragraph text appear as a link

image

@prmerger-automator prmerger-automator bot requested a review from TylerMSFT June 19, 2024 08:20
@prmerger-automator PRMerger Automator
Copy link
Contributor

@HarryGwinnell : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 45d31cd:

✅ Validation status: passed

File Status Preview URL Details
docs/build/reference/commands-in-a-makefile.md ✅Succeeded
docs/build/reference/contents-of-a-makefile.md ✅Succeeded
docs/build/reference/creating-a-makefile-project.md ✅Succeeded
docs/build/reference/defining-an-nmake-macro.md ✅Succeeded
docs/build/reference/inference-rules.md ✅Succeeded
docs/build/reference/inline-files-in-a-makefile.md ✅Succeeded
docs/build/reference/makefile-preprocessing.md ✅Succeeded
docs/build/reference/special-nmake-macros.md ✅Succeeded
docs/build/reference/using-an-nmake-macro.md ✅Succeeded
docs/cpp/if-else-statement-cpp.md ✅Succeeded
docs/cppcx/platform-intptr-value-class.md ✅Succeeded
docs/parallel/amp/reference/concurrency-direct3d-namespace-functions-amp.md ✅Succeeded
docs/parallel/amp/reference/concurrency-precise-math-namespace-functions.md ✅Succeeded
docs/parallel/amp/reference/norm-3-class.md ✅Succeeded
docs/parallel/amp/reference/tile-barrier-class.md ✅Succeeded
docs/parallel/concrt/reference/reader-writer-lock-class.md ✅Succeeded
docs/standard-library/scoped-allocator-adaptor-class.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator PRMerger Automator
Copy link
Contributor

PRMerger Results

Issue Description
Changed Files This PR contains more than 10 changed files.

@Court72
Copy link
Contributor

Court72 commented Jun 19, 2024

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jun 19, 2024
TylerMSFT
TylerMSFT approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - thank you for fixing that.

@TylerMSFT
Copy link
Collaborator

#sign-off

@ShannonLeavitt
Copy link
Contributor

@TylerMSFT - I see one minor inconsistency in the final correction in the diff view. Is this okay, or should the forward slash be removed in line 266?

image

@TylerMSFT
Copy link
Collaborator

Sharp eye. I fixed that one.

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 28f053e:

✅ Validation status: passed

File Status Preview URL Details
docs/build/reference/commands-in-a-makefile.md ✅Succeeded
docs/build/reference/contents-of-a-makefile.md ✅Succeeded
docs/build/reference/creating-a-makefile-project.md ✅Succeeded
docs/build/reference/defining-an-nmake-macro.md ✅Succeeded
docs/build/reference/inference-rules.md ✅Succeeded
docs/build/reference/inline-files-in-a-makefile.md ✅Succeeded
docs/build/reference/makefile-preprocessing.md ✅Succeeded
docs/build/reference/special-nmake-macros.md ✅Succeeded
docs/build/reference/using-an-nmake-macro.md ✅Succeeded
docs/cpp/if-else-statement-cpp.md ✅Succeeded
docs/cppcx/platform-intptr-value-class.md ✅Succeeded
docs/parallel/amp/reference/concurrency-direct3d-namespace-functions-amp.md ✅Succeeded
docs/parallel/amp/reference/concurrency-precise-math-namespace-functions.md ✅Succeeded
docs/parallel/amp/reference/norm-3-class.md ✅Succeeded
docs/parallel/amp/reference/tile-barrier-class.md ✅Succeeded
docs/parallel/concrt/reference/reader-writer-lock-class.md ✅Succeeded
docs/standard-library/scoped-allocator-adaptor-class.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator PRMerger Automator
Copy link
Contributor

PRMerger Results

Issue Description
Changed Files This PR contains more than 10 changed files.

@TylerMSFT
Copy link
Collaborator

#sign-off

@ShannonLeavitt ShannonLeavitt merged commit 85315ad into MicrosoftDocs:main Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerMSFT TylerMSFT TylerMSFT approved these changes

Assignees

@TylerMSFT TylerMSFT

Labels
aq-pr-triaged Tracking label for the PR review team Change sent to author needs-human-review ready-to-merge standard-libraries/subsvc visual-cpp/svc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HarryGwinnell @Court72 @TylerMSFT @ShannonLeavitt