Skip to content

Conversation

BIBlical33
Copy link
Contributor

Fix typo in insert functio

Fix typo in insert functio
Copy link
Contributor

@BIBlical33 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 4f1cde1:

✅ Validation status: passed

File Status Preview URL Details
docs/standard-library/basic-string-class.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@BIBlical33
Copy link
Contributor Author

I looked at the function signatures and found at least one non-standard function,
iterator insert(iterator iter); (what is this?), so this section needs revision.

@Court72
Copy link
Contributor

Court72 commented Jan 31, 2025

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jan 31, 2025
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning that up

@TylerMSFT
Copy link
Collaborator

#sign-off

@TylerMSFT
Copy link
Collaborator

#hold-off

Remove extraneous insert signature
Copy link
Contributor

Learn Build status updates of commit 44748e1:

✅ Validation status: passed

File Status Preview URL Details
docs/standard-library/basic-string-class.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out. I removed the spurious signature. I've created a workitem to come back later and go through all the function signatures to make sure they are correct.

@TylerMSFT
Copy link
Collaborator

#sign-off

@ttorble ttorble merged commit 721c1af into MicrosoftDocs:main Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants