Skip to content

Conversation

Rageking8
Copy link
Contributor

@Rageking8 Rageking8 commented Mar 30, 2025

Summary:

  • Add blockquotes for error message
  • Add link for stringizing operator
  • Add mention of charizing operator which can also emit C2162
  • Update example
    • Old example brings in stdio.h unnecessarily and redefines the print macro
    • New example also prevents any sort of macro redefinition warning
  • Edit metadata and some cleanups in "Compiler errors C2100 through C2199" since I was checking the error message there

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 85ce5cb:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-1/compiler-error-c2162.md ✅Succeeded
docs/error-messages/compiler-errors-1/compiler-errors-c2100-through-c2199.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@v-dirichards
Copy link
Contributor

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Mar 31, 2025
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Diff has odd change which doesn't show up in the file.
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good simplification.

Copy link
Contributor

Learn Build status updates of commit b4eab88:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-1/compiler-error-c2162.md ✅Succeeded
docs/error-messages/compiler-errors-1/compiler-errors-c2100-through-c2199.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@TylerMSFT
Copy link
Collaborator

#sign-off

@v-dirichards v-dirichards merged commit eb251b1 into MicrosoftDocs:main Mar 31, 2025
2 checks passed
Comment on lines 24 to 25
#define make_char1(c) #@ // C2162
#define make_char2(c) #@c // OK
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new part added which shows the expected macro formal parameter error similar to the make_string[1,2] macros, just with the charizing operator (#@) instead. But I do see how it might be a little misleading, so we can leave it out and maintain the status quo for now.

@Rageking8 Rageking8 deleted the expand-c2162-error-page branch April 1, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants