-
Notifications
You must be signed in to change notification settings - Fork 973
Expand C2162 error page #5279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand C2162 error page #5279
Conversation
@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit 85ce5cb: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Diff has odd change which doesn't show up in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good simplification.
Learn Build status updates of commit b4eab88: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
#sign-off |
#define make_char1(c) #@ // C2162 | ||
#define make_char2(c) #@c // OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the new part added which shows the expected macro formal parameter error similar to the make_string[1,2]
macros, just with the charizing operator (#@
) instead. But I do see how it might be a little misleading, so we can leave it out and maintain the status quo for now.
Summary:
stdio.h
unnecessarily and redefines theprint
macro