Skip to content

[desktop_drop] add namespace for Android platform #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

AdamVe
Copy link
Contributor

@AdamVe AdamVe commented Sep 6, 2023

This PR adds namespace to the plugin's build.gradle so that projects which use AGP8+ can use desktop_drop.

See Breaking change: namespace required in module-level build script for detailed information.

Other updates (including example):

  • bump to latest kotlin version
  • use latest pre 8 AGP and Gradle

Tested on devices running Android 8.1 and Android 14 beta.

@boyan01 boyan01 merged commit 334939d into MixinNetwork:main Sep 7, 2023
@AdamVe
Copy link
Contributor Author

AdamVe commented Sep 20, 2023

Thank you 👍🏻

@AdamVe
Copy link
Contributor Author

AdamVe commented Sep 25, 2023

Hi @boyan01, when do you plan the next release?

@EchoEllet
Copy link
Contributor

EchoEllet commented Jul 11, 2024

Updating the Android Gradle Plugin to a version that's higher than the latest tested one by the Flutter team caused unexpected issues in Release mode for more advanced use cases where you build a complete app with more plugins (I wasn't able to reproduce this in a blank Flutter project)

In the newer version of Flutter, Flutter will give you a warning (3.16 or 3.21).

As for the Kotlin version, this will require the users to use Kotlin 1.9.10 on their projects to use and build the project when using the plugin, I would recommend using the latest one by Flutter 1.7.10 if we don't need new advance Kotlin language features, it might also give you a warning for the Kotlin version though I'm not sure about this one since I haven't tested it myself.

See Comment #2223671370 for more details.

This PR adds namespace to the plugin's build.gradle so that projects which use AGP8+ can use desktop_drop.

In general, this change should be compatible with older versions of Gradle. Even if the project uses a different Gradle version than the default, the user can use a newer version as Gradle has strong compatibility.

@AdamVe
Copy link
Contributor Author

AdamVe commented Jul 14, 2024

@EchoEllet thanks for fixing the issue 👍🏻, I was not aware of this.

@EchoEllet
Copy link
Contributor

@EchoEllet thanks for fixing the issue 👍🏻, I was not aware of this.

You're welcome. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants