fix(win_toast): build fail on latest visual studio #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error logs:
win_toast_plugin.obj : error LNK2019: unresolved external symbol WINRT_IMPL_RoGetActivationFactory referenced in function "struct winrt::hresult __cdecl winrt::impl::get_runtime_activation_factory_impl<1>(struct winrt::param::hstring const &,struct winrt::guid const &,void * *)" (??$get_runtime_activation_factory_impl@$00@impl@winrt@@YA?AUhresult@1@AEBUhstring@param@1@AEBUguid@1@PEAPEAX@Z) [D:\a\1\s\build\windows\x64\plugins\win_toast\win_toast_plugin.vcxproj] DesktopNotificationManagerCompat.obj : error LNK2001: unresolved external symbol WINRT_IMPL_RoGetActivationFactory [D:\a\1\s\build\windows\x64\plugins\win_toast\win_toast_plugin.vcxproj] win_toast_plugin.obj : error LNK2019: unresolved external symbol WINRT_IMPL_RoOriginateLanguageException referenced in function "private: void __cdecl winrt::hresult_error::originate(struct winrt::hresult,void *,struct winrt::impl::slim_source_location const &)" (?originate@hresult_error@winrt@@AEAAXUhresult@2@PEAXAEBUslim_source_location@impl@2@@Z) [D:\a\1\s\build\windows\x64\plugins\win_toast\win_toast_plugin.vcxproj] DesktopNotificationManagerCompat.obj : error LNK2001: unresolved external symbol WINRT_IMPL_RoOriginateLanguageException [D:\a\1\s\build\windows\x64\plugins\win_toast\win_toast_plugin.vcxproj] D:\a\1\s\build\windows\x64\plugins\win_toast\Release\win_toast_plugin.dll : fatal error LNK1120: 2 unresolved externals [D:\a\1\s\build\windows\x64\plugins\win_toast\win_toast_plugin.vcxproj]