Fix desktop_drop Linux snap build failure due to missing stdlib.h include #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes compilation error when building Linux snap packages that use the
desktop_drop
plugin. The error occurred becausestd::getenv
was used without the proper header include.Error Details
When building a snap with
snapcraft --use-lxd
, the build failed with:/root/parts/desktop-drop-example/build/linux/flutter/ephemeral/.plugin_symlinks/desktop_drop/linux/desktop_drop_plugin.cc:69:29: error: no member named 'getenv' in namespace 'std'; did you mean simply 'getenv'?
Root Cause
The code was calling
std::getenv("XDG_CURRENT_DESKTOP")
without including<cstdlib>
or<stdlib.h>
, which provide thegetenv
function. While this might work in some build environments due to transitive includes, snap builds with stricter compilation flags exposed this missing dependency.Solution
#include <stdlib.h>
to provide access to thegetenv
functionstd::getenv
togetenv
for consistency with other C functions used in the same file (likestrcmp
,g_ascii_strdown
, etc.)Changes Made
Testing
getenv
functionality works as expectedFixes #424.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.