Skip to content

update: change all URLs to new org url, update assertion to attempt b… #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update: change all URLs to new org url, update assertion to attempt b… #23

wants to merge 1 commit into from

Conversation

zloeber
Copy link
Collaborator

@zloeber zloeber commented May 2, 2020

  • Change all URLs to new org url
  • Update build assertion to attempt building on powershell 5 or greater
  • minor fix to Plaster to fix pathing issues on Linux

@zloeber
update: change all URLs to new org url, update assertion to attempt b…
099727b 
…uilding on powershell 5 or greater, minor fix to Plaster to fix pathing issues on Linux
@zloeber zloeber requested a review from justin-p May 2, 2020 16:40
justin-p
justin-p requested changes May 3, 2020
View reviewed changes
Copy link
Collaborator

@justin-p justin-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks look. Only thing I would change is renaming .vscode/modulebuilddevelopment.code-workspace to .vscode/modulebuild.code-workspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-p justin-p justin-p requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zloeber @justin-p