Allow initiating client without authentication #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I understand correctly that initialization looks like this: const client = new Client({ host: '...' }) |
|
I got repro |
|
I think we need to change the logic in the public async sendRequest(request: AxiosRequestConfig, callback?: Callback): Promise<any> {
try {
request.headers = request.headers || {};
const authorization = request.headers.Authorization || getAuthentication(this.config, request);
if (!!authorization) {
request.headers.Authorization = authorization;
}
const response = await this.requestInstance.request(request);
... |
Yes, that's what's what causes the crash.
From what I can tell, that should work too, yeah. |
Will you make changes or should I do it? |
|
I've committed your suggestion to my branch 👍 |
MrRefactoring
approved these changes
Aug 6, 2020
|
Thank you for your contribution! |
|
Fixed in version 1.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While switching over from jira-connector to jira.js, I ran into an issue with setting up the client; in particular, it would crash every time I tried to initiate a client without any authentication.
Since I'm working on a public JIRA instance and my use case does only require read but not write access, I'd expect this module to allow me to use the APIs that are also publicly available.
This used to work without issues in jira-connector.
I found that the issue simply was that the
getAuthenticationhelper function returnedundefinedif no authentication was specified. Replacing thisundefinedwith an empty string solved the issue.There was a test that explicitly checked for this
undefined(which I changed in this PR), so I'm not sure if this was intentional and this issue is deeper in the core of axios?