-
Notifications
You must be signed in to change notification settings - Fork 84
460-Add sonarcloud question #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
template/{% if AddSonarCloud %}sonar-project.properties.jinja{% endif %}
Outdated
Show resolved
Hide resolved
Clean up did not work for me, see here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @fdiblen. Can you please check sonar-project.properties.jinja and clean up of the documents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @fdiblen. Thanks!
Description
This PR makes sonarcloud optional.
Related issues:
Instructions to review the pull request
Install the requirements
Test 1:
Step-1:
Run the command below and say 'yes' to sonarcloud question
Step-2:
Run the command below and say 'no' to sonarcloud question
What to check:
You should see the files below only when you say 'yes':
Check if there are mentions of sonar, sonarcloud or analysis in any file of the generated package.
Test 2: