Make every external link has target blank #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhamp
reviewed
Aug 8, 2025
|
Thanks for your effort here. I'm going to close this PR for a number of reasons, but mainly because I don't agree that this makes for a better UX. Users are able to Cmd/Ctrl+click to force their browser to open a link in a new tab when they want rather than when we decide, and this is a well understood behaviour available across most browsers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
config/filament.phpfilestr_getcsvare deprecated in PHP v8.4.0 Here the RefReason:
Opening external links in a new tab improves user experience by preventing users from unintentionally navigating away from our site. This is especially useful when linking to third-party resources, documentation, or external tools.
Implementation Details: