Skip to content

showModal() does not respect animated option #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsonevn opened this issue Jun 25, 2018 · 13 comments
Closed

showModal() does not respect animated option #5989

tsonevn opened this issue Jun 25, 2018 · 13 comments

Comments

@tsonevn
Copy link
Contributor

tsonevn commented Jun 25, 2018

Setting up the animated property to true on showModal method will not apply the animation for the modal page in Android. This scenario can be reproduced on the below-attached sample project.
Archive.zip


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@webleaf
Copy link

webleaf commented Aug 18, 2018

@tsonevn When will this issue be solved? It's core function and it does not work properly.
And also it will be nice if it would be possible to choose from which side Modal Page should appear (not only from bottom).

@Johanneke
Copy link

I am also waiting on this core functionality.

@tsonevn
Copy link
Contributor Author

tsonevn commented Oct 30, 2018

Hi all,
This issue is still under review. I can not commit to the exact time when the fix will be available.
Also, any PR, which provides a fix for this problem will be highly appreciated. You can check our contribution guidelines.

@kspearrin
Copy link

It's been a while. Is there any movement here?

@griffithstek
Copy link

I just implemented modals in our application. It's working great with iOS, but I've essentially had to fork the navigation between iOS and Android in order to maintain navigation animations on Android. This is an ugly solution though. Can we please bump this up the priority list?

@vahidvdn
Copy link

vahidvdn commented May 6, 2019

Any update on this?

It's working when fullscreen is set to false.

@NickIliev NickIliev removed the backlog label May 30, 2019
@bradmartin
Copy link
Contributor

bradmartin commented Aug 14, 2019

#6232 (comment)

@NickIliev see my comment there and if you all think that's sufficient for a PR to fix the animation not working on android when set.

code fix:

// set the animations to use on showing and hiding the dialog
window_1.setWindowAnimations(android.R.style.Animation_Dialog);

Below is how it looks in the project I'm working on.
modalanim

This is how Google Fit looks when presenting a modal/activity with the transition they use:
googlefitmodal

I know the docs say this animation suits non-full screen dialogs but it actually looks and performs really well on Android Q on my Pixel2 (https://developer.android.com/reference/android/R.style#Animation_Dialog)

I haven't tested what Android O, N, M, L look like with this option but I'm going to use it in a project bc it looks identical to Google Fit on android when it opens modals/activities

@NickIliev
Copy link
Contributor

@bradmartin the solution seems to work properly on first glance. Please post a PR so we could test extensively.

@manoldonev manoldonev changed the title [BUG] Issue with ModalPage animation. showModal() does not respect animated option Aug 20, 2019
@webleaf
Copy link

webleaf commented Aug 25, 2019

Don't see any changes. My fullscreen and animated modals still not animated.

@bradmartin
Copy link
Contributor

Seems to be working with the @next core-modules in my app. Maybe you haven't updated 🤔

@webleaf
Copy link

webleaf commented Aug 26, 2019

@bradmartin I've updated to 6.0.7 and see your commit there

@bradmartin
Copy link
Contributor

possibly could be an android OS version scenario that needs different handling. I've only tested this on Android P and Android10 beta. It worked on both, the .gif I posted is how it works on what I've tested.

@webleaf
Copy link

webleaf commented Sep 6, 2019

@bradmartin now it works (after several clean builds).
Now would be great to have ability to customize this transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants