Skip to content

fix(view): respect animated option for showModal() #7686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2019
Merged

fix(view): respect animated option for showModal() #7686

merged 2 commits into from
Aug 21, 2019

Conversation

bradmartin
Copy link
Contributor

PR Checklist

What is the current behavior?

Modals do not animate on android.

What is the new behavior?

Modals animate on android.

Fixes/Implements/Closes #[Issue Number].

#5989

@cla-bot cla-bot bot added the cla: yes label Aug 17, 2019
@manoldonev manoldonev changed the title closes #5989 fix(view): respect animated option for showModal() Aug 20, 2019
@manoldonev
Copy link
Contributor

test

@SvetoslavTsenov SvetoslavTsenov merged commit f3bd2e9 into NativeScript:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants