Skip to content

[Tabs] tabstripitem icons do not work #7436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vchimev opened this issue Jul 1, 2019 · 0 comments
Closed

[Tabs] tabstripitem icons do not work #7436

vchimev opened this issue Jul 1, 2019 · 0 comments
Labels
backlog bug os: ios

Comments

@vchimev
Copy link
Contributor

vchimev commented Jul 1, 2019 •
edited
Loading

Environment

  • tns-core-modules modules: 6.0.0-rc-2019-06-28-175837-02

Describe the bug

Setting iconSource on TabStripItem does not work for iOS.

To Reproduce - a sample tabs page.

Expected

Icons to be shown along with the titles.

Actual

actual
@vchimev vchimev changed the title [iOS] Tabs icons does not work [iOS Tabs] Tabs icons does not work Jul 1, 2019
@MartoYankov MartoYankov mentioned this issue Jul 1, 2019
Closed
87 tasks
@manoldonev manoldonev changed the title [iOS Tabs] Tabs icons does not work [Tabs] tabstripitem icons do not work Jul 3, 2019
vchimev added a commit that referenced this issue Jul 5, 2019
@vchimev
feat(ios-tabs): tab bar item appearance
9cdbd5a 
Implements #7436 and NativeScript/nativescript-angular#1884.
@vchimev vchimev mentioned this issue Jul 5, 2019
Merged
5 tasks
ADjenkov pushed a commit that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
feat(ios-tabs): tab bar item appearance
a740b6f 
Implements #7436 and NativeScript/nativescript-angular#1884.
ADjenkov pushed a commit that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
feat(ios-tabs): tab bar item appearance
bbde3cb 
Implements #7436 and NativeScript/nativescript-angular#1884.
ADjenkov pushed a commit that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
refactor(tabs): strip item appearance and creation (#7466)
c34a48a 
* test(e2e): add tab strip items pages

* fix(ios-tabs): a crash on swiping a content item

Fixes #7459.

* feat(android-tabs): create tab item spec from image and label

Implements NativeScript/nativescript-angular#1884 for Android.

* feat(ios-tabs): tab bar item appearance

Implements #7436 and NativeScript/nativescript-angular#1884.

* refactor(ios-tabs): move _hasImage and _hasTitle properties
ADjenkov pushed a commit that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
feat(ios-tabs): tab bar item appearance
fd1983f 
Implements #7436 and NativeScript/nativescript-angular#1884.
ADjenkov pushed a commit that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
refactor(bottom-navigation): strip item creation (#7477)
eb1ed3e 
* feat(ios-tabs): tab bar item appearance

Implements #7436 and NativeScript/nativescript-angular#1884.

* refactor(ios-tabs): move _hasImage and _hasTitle properties

* feat(ios-bottom-navigation): create tab bar from image nad label

Implements NativeScript/nativescript-angular#1893 for iOS.

* feat(android-bottom-navigation): create tab item spec from image and label

Implements NativeScript/nativescript-angular#1893 for Android.

* chore: remove console.logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog bug os: ios
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manoldonev @vchimev @NickIliev