Skip to content

[Tabs] A crash on swiping a content item #7459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vchimev opened this issue Jul 4, 2019 · 0 comments
Closed

[Tabs] A crash on swiping a content item #7459

vchimev opened this issue Jul 4, 2019 · 0 comments
Labels
bug os: ios

Comments

@vchimev
Copy link
Contributor

vchimev commented Jul 4, 2019 •
edited
Loading

Environment

  • tns-core-modules modules: 6.0.0-rc-2019-07-03-223248-02

Describe the bug

Swiping a content item of Tabs crashes the application on iOS.

To Reproduce

<Page>
  <Tabs id="tabs">

    <TabStrip>
      <TabStripItem title="TabStripItem 1">
      </TabStripItem>
    </TabStrip>

    <TabContentItem>
        <Label text="TabContentItem 1" />
    </TabContentItem>

  </Tabs>
</Page>

Output

CONSOLE LOG file:///app/bundle.js:62378:16: ### NativeScriptError: TypeError: undefined is not an object (evaluating 'nextItem.__controller')
CONSOLE LOG file:///app/bundle.js:62379:16: ### nativeException: undefined
CONSOLE LOG file:///app/bundle.js:62380:16: ### stackTrace: JS: 1   pageViewControllerViewControllerAfterViewController@file:///app/Users/vchimev/git/NativeScript/tns-core-modules/ui/tabs/tabs.ts:281:49
2   UIApplicationMain@[native code]
3   _start@file:///app/Users/vchimev/git/NativeScript/tns-core-modules/application/application.ts:321:26
@MartoYankov MartoYankov mentioned this issue Jul 4, 2019
Closed
87 tasks
vchimev added a commit that referenced this issue Jul 5, 2019
@vchimev
fix(ios-tabs): a crash on swiping a content item
f6df7e5 
Fixes #7459.
@vchimev vchimev mentioned this issue Jul 5, 2019
Merged
5 tasks
ADjenkov pushed a commit that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
fix(ios-tabs): a crash on swiping a content item
5dd9fbd 
Fixes #7459.
ADjenkov pushed a commit that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
fix(ios-tabs): a crash on swiping a content item
38eab69 
Fixes #7459.
ADjenkov pushed a commit that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
refactor(tabs): strip item appearance and creation (#7466)
c34a48a 
* test(e2e): add tab strip items pages

* fix(ios-tabs): a crash on swiping a content item

Fixes #7459.

* feat(android-tabs): create tab item spec from image and label

Implements NativeScript/nativescript-angular#1884 for Android.

* feat(ios-tabs): tab bar item appearance

Implements #7436 and NativeScript/nativescript-angular#1884.

* refactor(ios-tabs): move _hasImage and _hasTitle properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug os: ios
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manoldonev @vchimev @NickIliev