Skip to content

fix(ios): ListView _prepareCell null safety #10001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2022
Merged

fix(ios): ListView _prepareCell null safety #10001

merged 1 commit into from
Aug 20, 2022

Conversation

NathanWalker
Copy link
Contributor

closes #10000

PR Checklist

@cla-bot cla-bot bot added the cla: yes label Aug 20, 2022
@NathanWalker NathanWalker merged commit 56f861d into main Aug 20, 2022
@NathanWalker NathanWalker deleted the fix/#10000 branch August 20, 2022 04:32
@CatchABus
Copy link
Contributor

CatchABus commented Aug 23, 2022

@NathanWalker I tend to think this line stopped working because we made iOS native view reference disposable since 8.3 and it might even be useless now since there is a _removeView call that is done earlier.

See here: #9879
Perhaps this line was ignored so far because of that missing feature. If we want to keep it just to be sure, it may need an additional null check.
Like:

(<UIView>cell.view?.nativeViewProtected)?.removeFromSuperview?.();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List View null ref on cell reuse
2 participants