Skip to content

fix(ios): prevent transitionCoordinator usage during modal presentation #10153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

NathanWalker
Copy link
Contributor

PR Checklist

What is the current behavior?

Frame usage within a modal would cause content to be blank until fully opened.

What is the new behavior?

Frame usage within a modal now works as expected.

closes #10115

@nx-cloud
Copy link

nx-cloud bot commented Jan 3, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c9d819a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@cla-bot cla-bot bot added the cla: yes label Jan 3, 2023
@NathanWalker NathanWalker merged commit d138ac0 into main Jan 3, 2023
@NathanWalker NathanWalker deleted the fix/ios-modal-present-frame branch January 3, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal presentation issue after pull request #10075
2 participants