-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(android): ScrollView BadParcelableException #10213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): ScrollView BadParcelableException #10213
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1e33caa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Looks Good here. |
Our QA tester ran into the following error and it cause the app to crash after being left idle overnight and left running in the background. We are unfortunately unable to ascertain where exactly the exception was thrown.
|
This fix isn't included in 8.4.7. Should be available in 8.4.8-next releases though. |
I'm using 8.5.0 beta. Hopefully, the fix will be in this version when it is out soon. Ran into a similar crash just now when opening a pdf from a link in the app. |
Just to be clear, what version of @nativescript/core are you running I don't see a 8.5 beta of core, 8.4.8-next will have the fix. |
Ah, I see. It is a nativescript/core issue. I'm on 8.4.7 |
You can use @nativescript/core |
.../ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/ScrollSavedState.java
Show resolved
Hide resolved
This PR is already merged so let's post that stuff in the initial issue. #10239 |
PR Checklist
What is the current behavior?
Android scroll view throws
BadParcelableException
on state restore.What is the new behavior?
Android restores scroll view position state properly.
This also fixes:
HorizontalScrollView
restore value not to applyGridLayout
when it's nesting a scroll viewReference: https://stackoverflow.com/a/59299710
Fixes/Implements/Closes #10200 .