fix(core/platform): fixed types for sdkVersion and osVersion #10269
Conversation
These two return a number in Android (can't test iOS). Adding this fix would make expressions such as `Device.sdkVersion >= 23` possible without the need to add `@ts-ignore` before
Updated JSDoc to reflect Android behavior
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4cfc742. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
This reverts commit f8edee4.
|
@guillemc23 I reverted for the patch release as it does cause a breaking change. The platform types returned do in fact return strings however I think for 8.6 (when a breaking change like this could be introduced) it would likely be better to have it return just a number and let core do the parsing - it's likely debatable given the |
|
Understood! That's a great idea too. Thank you Nathan! |
PR Checklist
What is the current behavior?
Currently, both
Device.sdkVersionandDevice.osVersionreturn a number in Android. The typings state that this should be a string so expressions likeif (Device.sdkVersion >= 23) {...}are not possible.What is the new behavior?
I added
number | stringto the IDevice interface declaration so these expressions are allowed without the need to add@ts-ignore. I also updated the JSDoc to reflect this change.