Skip to content

fix(shared-transition): iOS snapshot opacity #10278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

rigor789
Copy link
Member

@rigor789 rigor789 commented Apr 26, 2023

PR Checklist

What is the current behavior?

In some cases a snapshot might end up being a transparent (empty) image.

What is the new behavior?

The snapshot ensures the layers opacity is non-zero for the snapshot.

@nx-cloud
Copy link

nx-cloud bot commented Apr 26, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c420858. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@cla-bot cla-bot bot added the cla: yes label Apr 26, 2023
@NathanWalker NathanWalker merged commit b8a548f into main Apr 26, 2023
@NathanWalker NathanWalker deleted the fix/ios-shared-element-snapshot-opacity branch April 26, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants