Skip to content

fix: prevent duplicate system classes #10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

farfromrefug
Copy link
Collaborator

If we call recreate on an activity the setRootViewCSSClasses is called again on the rootView. This would cause duplicate system css entries which could make theming fail. This fix ensure every system css entry is inserted only once

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

If we call recreate on an activity the `setRootViewCSSClasses` is called again on the `rootView`. This would cause duplicate system css entries which could make theming fail.
This fix ensure every system css entry is inserted only once
@cla-bot cla-bot bot added the cla: yes label Aug 1, 2023
@NathanWalker NathanWalker merged commit 74e6814 into main Aug 2, 2023
@NathanWalker NathanWalker deleted the farfromrefug-patch-1 branch August 2, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants