fix(ios): Shadow layer origin point update #10376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 1 commit into NativeScript:main from CatchABus:shadow-animation-origin-fix

Sep 7, 2023

Contributor

CatchABus commented Sep 7, 2023

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

iOS shadow layers do not respect origin point.

What is the new behavior?

iOS shadow layers will respect origin point. This is a fix for #10374 (comment)


          fix(ios): Shadow layer origin point update

ceb68b2

cla-bot bot added the cla: yes label

NathanWalker approved these changes

View reviewed changes

NathanWalker merged commit f54ebbb into NativeScript:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels