feat(android): allow shared element transition to work with ListView/CollectionView/Pager #10411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation it would not work because the collectionview would not have time to realize the cells which you would want to use as shared element.
The idea is to defer a bit for :
PageTransition
so that each use case can be handled.A few notes :
PageTransition
constructor parameters to be an object. Would be less messy, though it would be a breaking change. But as it is quite a new feature, would that be acceptable?PageTransition
has aonTransitionEnd
which revertsetTransitionName
to null for all presenting views. The reason is that my fork usesadd
for fragments instead ofreplace
. Thus back navigation fragments are still existing. And if you use the samesetTransitionName
for multiple pages in deep navigation it would fail/crash. I did not add it here as it is unecessary. Just a note for the future!