fix(css): prevent shorthand parse error on 'unset' and 'inset' #10424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 4 commits into main from chore/cleanups

Nov 2, 2023

Contributor

NathanWalker commented Oct 25, 2023 •

edited

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Usage of shadow css with unset in shorthand would result in css parse error.

What is the new behavior?

unset is no longer inadvertently parsed as a color.

Fixes/Implements/Closes #[Issue Number].


          fix(css): prevent shorthand parse error on 'unset' and 'inset'

9d005ba

cla-bot bot added the cla: yes label

NathanWalker added hacktoberfest and removed cla: yes labels


          chore: tests

98ebecd

cla-bot bot added the cla: yes label

NathanWalker added 2 commits

November 2, 2023 10:57


          chore: bump cli

f6d89eb


          Merge branch 'main' into chore/cleanups

7e0bc72

NathanWalker merged commit d70b48b into main

NathanWalker deleted the chore/cleanups branch

November 2, 2023 20:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes hacktoberfest