-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: set modal dialog root view parent #10443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…le to access the `ns-root` class which comply with css specs (for example to read root css variables)
on iOS as the UILayoutViewController can be used for other widget we need to let it know it is for modal so that it still loads/unloads the view (there was a test for parent).
I think it's more like a feature than a fix. Old docs state that you have to use |
You still can. Ns-modal only apply to modals |
I see your point but will this implementation work for the case when root view is a Frame? That class seems to have a special handling for UPDATED: The same applies to other views that can be used as root views. |
@vallemar yes it does. But not when you start modifying them from yes. From what you have root and modal properties are actually not the same |
@CatchABus it should not change anything. EachChild and parent are decoupled. Setting the parent does not imply it will be in eachChild. It won't ! |
now the dialog root view has the
Application
rootView
as parent to be able to access thens-root
class which comply with css specs (for example to read root css variables)