fix(css): box-shadow none handling #10445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 1 commit into main from fix/box-shadow-none

Nov 19, 2023

Contributor

NathanWalker commented Nov 19, 2023 •

edited

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

box-shadow: none had slightly different behavior between platforms (ios would create CALayers unnecessarily and Android would throw error).

What is the new behavior?

This none condition is now handled the same across both and avoids any unnecessary work.

closes #10403


          fix(css): box-shadow none handling

b3f8910

closes #10403

cla-bot bot added the cla: yes label

CatchABus approved these changes

View reviewed changes

Contributor

CatchABus left a comment

Seems good. No problems occured after testing.

NathanWalker merged commit 6744009 into main

NathanWalker deleted the fix/box-shadow-none branch

November 19, 2023 23:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels