fix(android): crash with material components #10450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`setSecureAndKeyboardType` needs to use `nativeTextViewProtected` As a reminder in text base components there is `nativeViewProtected` and `nativeTextViewProtected`. The reason is that material components (and maybe other) differentiate the layout and the textfield itself inside one view. A while back i made a PR for the whole N to support those two getters. But we need to remain careful on which one we use everytime
CatchABus
requested changes
Nov 27, 2023
There was a problem hiding this comment.
I agree we should be more careful and stick to it.
Since we're doing this, I found few more references that could be corrected: https://github.com/NativeScript/NativeScript/blob/main/packages/core/ui/text-base/index.android.ts#L508
|
@CatchABus actually this case does not matters a lot as setTextStroke is a method of the custom component used for label. dont think we use it for textfield though. might even crash with N textfield. we should check for method existence |
CatchABus
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setSecureAndKeyboardTypeneeds to usenativeTextViewProtectedAs a reminder in text base components there isnativeViewProtectedandnativeTextViewProtected. The reason is that material components (and maybe other) differentiate the layout and the textfield itself inside one view. A while back i made a PR for the whole N to support those two getters. But we need to remain careful on which one we use everytimePR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].