Skip to content

fix: disable accessibilty for layout views. Seems unecessary and can … #10482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

farfromrefug
Copy link
Collaborator

…be enabled on a per view basis

PR Checklist

What is the current behavior?

Accessibility features are enabled on all Nativescript Views

What is the new behavior?

Now accessibility is enabled by default only for non-layout Views

Fixes/Implements/Closes #[Issue Number].

@farfromrefug farfromrefug requested a review from rigor789 January 24, 2024 17:43
@cla-bot cla-bot bot added the cla: yes label Jan 24, 2024
@NathanWalker NathanWalker merged commit 3bd6d9b into NativeScript:main Feb 10, 2024
edusperoni added a commit that referenced this pull request Apr 15, 2024
farfromrefug added a commit that referenced this pull request Apr 15, 2024
where `WebView` would have `setFocusable` set to false `isUserInteractionEnabled` was true.
This would prevent input with keyboard to work in `WebView`
NathanWalker added a commit that referenced this pull request Apr 15, 2024
where `WebView` would have `setFocusable` set to false `isUserInteractionEnabled` was true.
This would prevent input with keyboard to work in `WebView`

Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants