Skip to content

fix(android): Add null check on Android transition #10528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix(android): Add null check on Android transition #10528

merged 1 commit into from
Apr 24, 2024

Conversation

asharghi
Copy link
Contributor

PR Checklist

@cla-bot cla-bot bot added the cla: yes label Apr 24, 2024
SeanKelly369
SeanKelly369 approved these changes Apr 24, 2024
View reviewed changes
Copy link

@SeanKelly369 SeanKelly369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can't see any potential null pointer exceptions.

@vallemar
Copy link
Contributor

vallemar commented Apr 24, 2024 •
edited
Loading

@asharghi I see that state is used later in the method. https://github.com/NativeScript/NativeScript/pull/10528/files#diff-b8d0f1a2f61cebd65f19eb6a02409e959992ce5f82d11bc1d44507b3d9f86f65R229-R233

Will this cause errors here or am I wrong?

@asharghi
Copy link
Contributor Author

@asharghi I see that state is used later in the method. https://github.com/NativeScript/NativeScript/pull/10528/files#diff-b8d0f1a2f61cebd65f19eb6a02409e959992ce5f82d11bc1d44507b3d9f86f65R229-R233

Will this cause errors here or am I wrong?

isNumber(pageEnd?.duration) would return false so pageEnd won't be used after that. I think it will be fine.

@NathanWalker NathanWalker merged commit 632a348 into NativeScript:main Apr 24, 2024
@asharghi asharghi deleted the patch-1 branch April 25, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanWalker NathanWalker NathanWalker approved these changes

+1 more reviewer

@SeanKelly369 SeanKelly369 SeanKelly369 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asharghi @vallemar @NathanWalker @SeanKelly369