Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): consistent box-shadow radius blur #10583

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SeanKelly369
Copy link

The radius blurring has been adjusted in iOS to match that in Android

PR Checklist

What is the current behavior?

The box-shadow radius amount differs in iOS compared to Android

What is the new behavior?

The box-shadow radius amount in iOS matches Android

BREAKING CHANGES: none

@cla-bot cla-bot bot added the cla: yes label Jul 11, 2024
@NathanWalker NathanWalker changed the title Box-Shadow: radius blurring scaling fix(ios): consistent box-shadow radius blur Jul 12, 2024
@NathanWalker
Copy link
Contributor

This would be considered a breaking change mainly because an app may quite drastically change it's visual appearance with this change - to many in unexpected way, however it's a welcome change but it would be considered a breaking change and would need to go into a minor release likely (vs a patch).

@NathanWalker NathanWalker added this to the 8.9 milestone Jul 12, 2024
@NathanWalker
Copy link
Contributor

Possible to post a quick screenshot of iOS/Android side by side on this?

@SeanKelly369
Copy link
Author

SeanKelly369 commented Jul 13, 2024

@NathanWalker sure thing. Take a look at the red box shadow at the bottom.

This is how it looks on Android:
Drop_Shadow_Android

This is how it looks on an iPhone 15 after the changes:
Drop_Shadow_after_iPhone15

This is how it currently looks on an iPhone 15 in production:
Drop_Shadow_current_iPhone15

@CatchABus
Copy link
Contributor

It's worth considering whether we should value native look-and-feel over cross-platform consistency or not.
Because in iOS, we have actual support for a complete shadow styling while android merely offers elevation and blur filter (with the exception of canvas shadow layer).

If we had to do such a calibration, I think android should match the iOS look 'n feel and not vice-versa.

@CatchABus
Copy link
Contributor

@SeanKelly369 I noticed some designers divide blur by screen scale.
I found a Sketch vs iOS shadow discussion here: https://stackoverflow.com/questions/34269399/how-to-control-shadow-spread-and-blur
Can you check if dividing blur gives you the ideal result?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants