fix(ios): Proper drawing bounds for colored borders #10600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 2 commits into NativeScript:main from CatchABus:ios-border-color-fix

Aug 5, 2024

Contributor

CatchABus commented Aug 5, 2024 •

edited

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

There are cases when iOS views display extra borders. That is because layer fill drawing does not work well with fractional coordinates.

What is the new behavior?

iOS view colored borders will display properly.

Fixes/Closes #10548.


          fix(ios): Proper drawing bounds for colored borders

fb7b693

cla-bot bot added the cla: yes label

NathanWalker approved these changes

View reviewed changes


          Merge branch 'main' into ios-border-color-fix

2fed8b2

NathanWalker merged commit 75c8e94 into NativeScript:main

0 of 3 checks passed

CatchABus mentioned this pull request

fix(ios): Use anti-aliasing for accurate borders #10619

Merged

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels