chore: update typescript experience #10628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now when using `types.isString` for example, typescript will understand that the arg is actually a string and propose intelisense afterward
NathanWalker
previously approved these changes
Sep 24, 2024
rigor789
previously approved these changes
Sep 24, 2024
10ff999
NathanWalker
approved these changes
Jan 14, 2025
Comment on lines
+21
to
27
| export function isObject(value: any): value is Record<string,any> { | ||
| if (!value) { | ||
| return false; | ||
| } | ||
|
|
||
| return typeof value === 'object'; | ||
| } |
There was a problem hiding this comment.
this is an invalid type guard.
an array, date, regex, class would also result in true but is not of type Record<string, any>
There was a problem hiding this comment.
@farfromrefug you should take a look at this
There was a problem hiding this comment.
@offizium-berndstorath indeed it would not work with Date/Regex ... However i dont think that s what that method was intended for seeing where it is used. In this case i think we should have a isDate, isRegex ...
I mean i dont see any place where isObject would be called with a Date, Regex, ...
There was a problem hiding this comment.
@farfromrefug you are correct. these are not really what im concerned about. its mostly about array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now when using
types.isStringfor example, typescript will understand that the arg is actually a string and propose intelisense afterwardPR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].