You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
Right now, typography is a bit inconsistent between the two platforms and MDN specs.
More specifically, line-height does not act as a height and its visual result is quite different than that of browser.
What is the new behavior?
Small android size defaults cleanup
Added support for line-height dip and percentage units and updated calculation to be closer to that of browser
Corrected UIButton letter-spacing calculation which used the deprecated font property to read font size
Corrected iOS Button formatted text default color (it's different than the button with regular text)
BREAKING CHANGES:
Line height will apply like a height as the name indicates while {N} has long been using it as line-spacing. This might cause strange visual changes in apps.
After a bit of consideration, I removed all changes regarding line-height.
The reason is that the css property can also accept a multiplier value which is one of the recommended usages in the web.
NativeScript css dip values are unitless, so if we suddenly treat the line-height value as dip then we have no way of setting a multiplier.
In few words, it's best to leave it as is.
EDITED: Added line-height percentage unit to make up for the lack of multiplier value.
So we can parse raw number as dip without any worries and use percentage value whenever needed.
All changes regarding letter-spacing unit have been removed from this PR.
We might re-visit that case in the future provided that we don't skip the em native support since it's very useful when dealing with responsive layouts.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now, typography is a bit inconsistent between the two platforms and MDN specs.
More specifically, line-height does not act as a height and its visual result is quite different than that of browser.
What is the new behavior?
BREAKING CHANGES: