fix(crypto): getRandomValues array returned #10658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 2 commits into main from fix/crypto-random-values

Jan 14, 2025

Contributor

NathanWalker commented Dec 18, 2024 •

edited

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

getRandomValues would not return the array

What is the new behavior?

getRandomValues now returns the array


          fix(crypto): ensure typed array is returned

05b0435

NathanWalker changed the title ~~fix(crypto): ensure typed array is returned~~ fix(crypto): getRandomValues array returned


          Merge branch 'main' into fix/crypto-random-values

74d52ae

NathanWalker merged commit 603b2dc into main

0 of 3 checks passed

NathanWalker deleted the fix/crypto-random-values branch

January 14, 2025 02:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet