Skip to content

fix: hmr for hermes engine #10669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2025
Merged

fix: hmr for hermes engine #10669

merged 1 commit into from
Jan 19, 2025

Conversation

ammarahm-ed
Copy link
Contributor

@ammarahm-ed ammarahm-ed commented Jan 19, 2025 •
edited
Loading

Hermes does not support async arrow functions yet.

PR Checklist

What is the current behavior?

What is the new behavior?

@ammarahm-ed
fix: hmr for hermes engine
064b2fa 
Hermes does not support async arrow functions yet
@CatchABus
Copy link
Contributor

@ammarahm-ed I'm worrying a bit that someone could unintentionally break this again in few years or so.
Might be a good idea to add a comment there as an explanation.

@NathanWalker NathanWalker changed the base branch from main to feat/napi January 19, 2025 19:41
@NathanWalker
Copy link
Contributor

We're keeping these changes on a feat/napi branch to keep separate from main while testing is ongoing. That will allow us to later do a single PR for deeper discussion altogether for final determinations on main handling. Merging into branch here - note.

@NathanWalker NathanWalker merged commit a827a3d into NativeScript:feat/napi Jan 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ammarahm-ed @CatchABus @NathanWalker